-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some more stubs for array functions #4271
Conversation
* | ||
* @psalm-pure | ||
*/ | ||
function array_intersect_ukey(array $arr, array $arr2, array ...$arr3, callable $keyCompareFunc): array {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brackets mentioned twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @andrew-demb
Please remove the six stubs that are already covered by return type providers in Psalm (currently |
@muglug done. Just for the sake of understanding, are return type providers used when annotations are not enough to type correctly the function? |
Yes, exactly. When I introduced conditional return types I removed (I think) all the return type providers that were simple enough to be implemented instead as conditional return types. |
Thanks! |
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
* add some more stubs for array functions * add function brackets to stubs * add parameter names * remove redundant brackets * remove stubs already defined in return type providers
This adds some more stubs for array functions